Skip to content

Conversation

@sanjayankur31
Copy link
Member

No description provided.

This tweaks a few functions to allow jnml output to be returned for
programmatic access. At the moment, even though lots of things use jnml,
we only return it for validation.

This is not a breaking/backwards incompatible change since it does not
change the function signature or return value by default.
It is therefore, a backwards compatible enhancement.

Fixes #126
@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement S: ready for review Status: ready for review P: low Low priority labels Oct 11, 2021
@sanjayankur31 sanjayankur31 self-assigned this Oct 11, 2021
@sanjayankur31 sanjayankur31 linked an issue Oct 11, 2021 that may be closed by this pull request
@jonrkarr
Copy link

An option to get an error message as a string is great. The new output string is much more readable.

I tried the method, and the first Boolean output is true even for invalid models (where validation concludes with the message Validated 1 files: 0 passed, 1 failed).

Also, could you make the same change to validate_neuroml1?

@sanjayankur31
Copy link
Member Author

I tried the method, and the first Boolean output is true even for invalid models (where validation concludes with the message Validated 1 files: 0 passed, 1 failed).

Ah, that's odd. I'll look into that.

Also, could you make the same change to validate_neuroml1?

I'll do that, sure.

Please note: NeuroML v1 is deprecated and should not be used, and we intend to start dropping all of these functions soon (they only exist because we have to start dropping bits in the java stack and then slowly propagate all of that to the python bits).

@jonrkarr
Copy link

We don't intend to encourage people to use older versions. We just aim to help people use older published models.

@pgleeson
Copy link
Member

Looks good.

@pgleeson pgleeson merged commit f40e21f into development Oct 27, 2021
@jonrkarr
Copy link

We can deploy this online when the next version is released.

@sanjayankur31 sanjayankur31 deleted the feat/issue-126 branch July 26, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P: low Low priority S: ready for review Status: ready for review T: enhancement Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose programmatic access to error messages

4 participants