-
Notifications
You must be signed in to change notification settings - Fork 35
Feat/issue 126: allow programmatic access to output of jnml from validation #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This tweaks a few functions to allow jnml output to be returned for programmatic access. At the moment, even though lots of things use jnml, we only return it for validation. This is not a breaking/backwards incompatible change since it does not change the function signature or return value by default. It is therefore, a backwards compatible enhancement. Fixes #126
|
An option to get an error message as a string is great. The new output string is much more readable. I tried the method, and the first Boolean output is true even for invalid models (where validation concludes with the message Also, could you make the same change to |
Ah, that's odd. I'll look into that.
I'll do that, sure. Please note: NeuroML v1 is deprecated and should not be used, and we intend to start dropping all of these functions soon (they only exist because we have to start dropping bits in the java stack and then slowly propagate all of that to the python bits). |
|
We don't intend to encourage people to use older versions. We just aim to help people use older published models. |
Note: v1 is deprecated
|
Looks good. |
|
We can deploy this online when the next version is released. |
No description provided.